We noticed that in woocommerce-multilingual/inc/class-wcml-comments.php, the maybe_invalidate_comment_cache method is hooked to pre_get_comments and calls wp_cache_flush_group('comment-queries') on every product page load:
phppublic function maybe_invalidate_comment_cache( $query ) {
if ( isset( $query->query_vars['post_id'] ) && $query->query_vars['post_id'] ) {
$product_id = $query->query_vars['post_id'];
if ( 'product' === get_post_type( $product_id ) ) {
wp_cache_flush_group( 'comment-queries' );
}
}
}
On our store this is causing significant Redis slowdowns because the flush operation has to scan millions of keys each time a product page is visited. We can see this clearly in our Redis slow log where the same EVAL command scanning comment-queries:* takes 1.5-1.7 seconds and repeats every few seconds continuously.
Is this behavior intentional? Is there a reason the cache needs to be flushed on every product page load rather than only when a review is actually added or changed?
Thanks for reaching out and for the detailed report.
I am raising this directly to our development team to review. We recently conducted an analysis against our WCML plugin and object cache, and this logic was introduced as a result - I am getting our development team involved and we will check it as soon as possible.
Until I get a response, you may want to disable the whole logic by commenting out the line 80 of the file that you referenced:
I can not state if there can be some side effect of this workaround, to be honest, until I get some feedback from our development team. You might experience some comments not appearing right after they are created, or even some mismatch between the language of the content being visited and the comments being displayed.
Thank you Juan. I can confirm that your hotfix worked and the situation stabilized. Please kindly keep us posted on a long-term solution so we don't have to rely on commenting out that specific line.
I think the issue might unknowingly slow down a lot of websites from many of your customers, and it is quite hard to identify this problem, so your help in escalating this to the devs is much appreciated.
Our development team included it into their list of tasks for the current development cicle, so we can push a fix for the issue in the next release for WCML. Unfortunately, the release date is still not defined, so I can not provide you with a good estimation - it should probably land by the end of this month or early next one, but do take this with a pinch of salt.
If there happens to be any WCML release earlier than that, I am monitoring the task so I make sure it gets included.
