[Closed] trid collision in maybe_retrive_trid_again() causes translation unlinking after slug rename

WPML Version: 4.9.2 (also present in 4.8.5)
Environment: WordPress 6.x, WooCommerce, WPML Multilingual CMS + WooCommerce Multilingual

Steps to Reproduce:

1. Have a published product with a translation (e.g. English + French)
2. Edit the English product — change the product name and URL slug
3. Save the product
4. The translation becomes unlinked from its English source in WPML
5. Attempting to reconnect via "Connect with translations" fails — WPML flags a conflict

Root Cause:
The method maybe_retrive_trid_again() in inc/actions/wpml-tm-post-actions.class.php (line 211) has two issues:

private function maybe_retrive_trid_again( $trid, $post ) {
global $wpdb, $sitepress;
$element_type_from_trid = $wpdb->get_var(
$wpdb->prepare(
"SELECT element_type FROM {$wpdb->prefix}icl_translations WHERE trid=%d",
$trid
)
);
if ( $element_type_from_trid && $post->post_type !== $element_type_from_trid ) {
$trid = $sitepress->get_element_trid( $post->ID, 'post_' . $post->post_type );
}
return $trid;
}

Issue 1 — Type comparison mismatch (line 214):
$post->post_type returns e.g. product, but $element_type_from_trid returns e.g. post_product. These will never match, so the condition is always true when a trid exists. The comparison should be: 'post_' . $post->post_type !== $element_type_from_trid

Issue 2 — Unfiltered SQL query (line 213):
The query SELECT element_type FROM wp_icl_translations WHERE trid=%d returns the first row for that trid without filtering by element_type. If a trid has been corrupted (e.g. contains both a post_product and a post_page entry), the returned element_type is unpredictable and can cause cascading unlinking.

Suggested fix:

private function maybe_retrive_trid_again( $trid, $post ) {
global $wpdb, $sitepress;
$element_type = 'post_' . $post->post_type;
$element_type_from_trid = $wpdb->get_var(
$wpdb->prepare(
"SELECT element_type FROM {$wpdb->prefix}icl_translations WHERE trid=%d AND element_type=%s",
$trid,
$element_type
)
);
if ( ! $element_type_from_trid ) {
$trid = $sitepress->get_element_trid( $post->ID, $element_type );
}
return $trid;
}

Impact:
- Translation links are silently broken after a slug rename
- Cannot be fixed from the WPML admin UI — requires direct SQL correction