[Escalated to WPML Developers team] WPML_WPSEO_Redirection flushes object cache on every request

I am trying to: Have a fast website. Serve cached pages without database queries.

Link to a page where the issue can be seen: All pages on hidden link

I expected to see: No database queries after warming object cache.

Instead, I got:

- 231 cache misses, followed by
- 199 cache sets in WPML_URL_Cached_Converter->convert_url(), due to
- 1 invocation of WPML_WPSEO_Redirection::clear_converter_cache_for_home_url()

Stack Trace:

WPML_WP_Cache->flush_group_cache()
wp-content/plugins/sitepress-multilingual-cms/classes/utilities/class-wpml-wp-cache.php:71
WPML_WPSEO_Redirection::clear_converter_cache_for_home_url()
wp-content/plugins/wp-seo-multilingual/classes/class-wpml-wpseo-redirection.php:49
WPML_WPSEO_Redirection->is_redirection()
wp-content/plugins/wp-seo-multilingual/classes/class-wpml-wpseo-redirection.php:28

Apparently the invocation of clear_converter_cache_for_home_url() is hardcoded into WPML_WPSEO_Redirection->is_redirection(), but this is invoked on every page request!

The invocation is commented with the following in your code:

	// The unfiltered URL got cached so we need to flush the group.
	self::clear_converter_cache_for_home_url();

It is not clear what this is referring to. The function is not filtering or converting any URLs afterwards. There does not seem to be a point in clearing the cache.

Proposed solution: Remove the hardcoded invocation without replacement.

Thanks,
Daniel Kudwien
hidden link
hidden link