[Escalated to 2nd Tier] Correct way to translate get_page_by_path(), especially within wp-json?

Hi Steffen

I've been doing some tests on my own site, and I think the difficulty arises because you include the language directory for the default language (i.e. de is the default language and your paths include a de directory, e.g. site.com/de/impressum rather than site.com/impressum).

Using apply_filters( 'wpml_permalink', 'hidden link', 'en', true ); won't return the permalink of the translated page because the /de/ in the source permalink for the default language confuses the filter.

If you used apply_filters( 'wpml_permalink', 'hidden link', 'en', true ); it would likely work.

This is in spite of the fact that it is WPML settings which specify the default language should use a directory in its URL structure.

That looks like a bug to me, but I'm double-checking with colleagues.

If you don't need your default language in a directory you could of course remove it, but once I get word back from my colleagues confirming the above, I can look into an alternative solution that works with the default language in directories.

I have escalated the issue as a bug, so hopefully we can expect a fix before too long.

But in the meantime, given that omitting the language directory from the URL passed to the wpml_permalink filter will return the correct permalink for the translated post, I thought the easiest solution would be to strip that language directory from the URL before passing it through the filter.

Something like this:

    $slug = "impressum";

    $default_permalink = home_url( $slug );

    $default_permalink_modified = str_replace( '/de/', '/', $default_permalink );
    
    $translated_permalink = apply_filters( 'wpml_permalink', $default_permalink_modified, 'en', true );

$translated_permalink will then have the correct result.

With this variant of the test site with German as the default language isn't working very well at all, and I've asked a colleague to double-check things before I share it with you.

Thanks for your patience.

Hi,

I am Sumit from 2nd tier support. Nigel is off today so I will communicate with you.
I hope it is fine.

I am not sure what is wrong with the site. But looking at the options "wpml_resolved_url_persist" this is definitely wrong. There are two entries for one URL, one with a trailing slash and another without a trailing slash.
That's why we suggest saving the permalinks after making the changes to plugin/code as saving permalinks delete that option and rebuilt again on visiting the page.
I hope you did that after uploading the patched plugin.

Since I can not check it is a local site. Will you help to reproduce the issue on our sandbox site if we share it with you?

About the REST issue:-
This is kind of expected, I am not pretty sure (have not checked it yet in logs) but we did some changes to the code to not to adjust the IDs in REST as when passing the ID the expected results should be the object of that ID. There were a number of requests for this feature.

You can adjust the IDs in the callback or before passing to the request if REST client is inside the WP too.
https://wpml.org/wpml-hook/wpml_object_id/

Since this is a different topic not related to the original issue I would suggest opening a new ticket if you need further help with this.

Thanks