[Resolved] slow down on mass price update

Hi,

Sorry for the delay.

I see in the emails the delete command has been re-started.
Please note, if you re-start the command it will scan each image and look for duplicate files, if no files are found it says 0 files deleted. But each time you will run it it will run.

So I would suggest halting it once it starts logging "Deleted 0 items for image" continuously.

About the warning, I saw no error on my system so I checked the code added by your team and found, by mistake they have removed the slashes in the code.

In code, I provided, this line was

use WPML\Media\Option;

but added as

use WPMLMediaOption;

Please see the screenshot for more details.

Please copy the code again from here https://wpml.org/forums/topic/slow-down-on-mass-price-update/page/7/#post-13518127 and paste it correctly.

Thanks

Hi,

Okay then let it be. But I shared you when you can predict the process is finished and running without real output.

About the code error, yes that is what I predicted. Please share the direct link with your team, this is public forum so they can copy directly from this thread.

This is the link https://wpml.org/forums/topic/slow-down-on-mass-price-update/page/6/#post-13518127 for non-logged-in users.

Thanks

Hi,

I spent 10 to 15 min on your website and there were only two processes running.
- Server state plugin process
- WordPress heartbeat process.

There was no duplication process running from WPML. Also, this is expected that it won't run again, I think there is no way left to trigger the process.

Thanks

Hi,

The query you posted in the screenshot of the mail is a known issue. We have this slow query and this will be improved in future versions of WPML.

If you need a patch to make it work then please follow these steps:-
#1 Make sure you have a complete backup of site files and DB (Just a good practice.)
#2 Edit the file wp-content\plugins\sitepress-multilingual-cms\inc\taxonomy-term-translation\wpml-term-translation.class.php
#3 and replace the function

	private function maybe_warm_term_id_cache() {

		if ( ! isset( $this->ttids ) || ! isset( $this->term_ids ) ) {

			$data           = $this->wpdb->get_results(
				'	SELECT wpml_translations.element_id, tax.term_id, tax.taxonomy
													 ' . $this->get_element_join() . "
													 JOIN {$this->wpdb->terms} terms
													  ON terms.term_id = tax.term_id
													 WHERE tax.term_id != tax.term_taxonomy_id",
				ARRAY_A
			);
			$this->term_ids = array();
			$this->ttids    = array();
			foreach ( $data as $row ) {
				$this->ttids[ $row['term_id'] ]                     = isset( $this->ttids[ $row['term_id'] ] )
					? $this->ttids[ $row['term_id'] ] : array();
				$this->ttids[ $row['term_id'] ][ $row['taxonomy'] ] = $row['element_id'];
				$this->term_ids[ $row['element_id'] ]               = $row['term_id'];
			}
		}
	}

with

	private function maybe_warm_term_id_cache() {
		$cached_value = wp_cache_get('wpml_adjust_ttid_for_term_id', 'wpml_terms');
		
		if ( empty($cached_value) ) {

			$data           = $this->wpdb->get_results(
				'	SELECT wpml_translations.element_id, tax.term_id, tax.taxonomy
													 ' . $this->get_element_join() . "
													 JOIN {$this->wpdb->terms} terms
													  ON terms.term_id = tax.term_id
													 WHERE tax.term_id != tax.term_taxonomy_id",
				ARRAY_A
			);
			$this->term_ids = array();
			$this->ttids    = array();
			foreach ( $data as $row ) {
				$this->ttids[ $row['term_id'] ]                     = isset( $this->ttids[ $row['term_id'] ] )
					? $this->ttids[ $row['term_id'] ] : array();
				$this->ttids[ $row['term_id'] ][ $row['taxonomy'] ] = $row['element_id'];
				$this->term_ids[ $row['element_id'] ]               = $row['term_id'];
			}
			
			wp_cache_set('wpml_adjust_ttid_for_term_id', [
				'term_ids'	=> $this->term_ids,
				'ttids'		=> $this->ttids
			], 'wpml_terms');
		} else {
			$this->term_ids = $cached_value['term_ids'];
			$this->ttids = $cached_value['ttids'];
		}
	}

#4 Then add the below code in theme functions.php

add_action('clean_term_cache', function(){
	wp_cache_delete('wpml_adjust_ttid_for_term_id', 'wpml_terms');
});

These changes will cache the query results in the object caching which I hope you have. So this will not fire every time.

About the logs you sent me there are 400+ queries in the logs coming from different plugins/themes I am not sure which one to blame the WPML.
If a query shows icl tables in the statement it does not mean this is fired by WPML it just means that WPML joins the table to filter the results. So adding join could cost the time but not the entire query time taken by WPML also this is not clear how these queries were fired.

I would suggest sticking with the query monitor plugin this gives me the idea of action when the query is fired and details about the query.

Thanks