Your commitment and consistency are the key elements here. Thank you for recognizing the significance of this event.
The screenshots demonstrate accurate calculations:
The USD now correctly serves as the starting point for calculations using the current price of the existing subscription in the correct currency - USD.
Additionally, the ILS calculation appears to function as well as it always has.
I will conduct these tests and respond again:
First test: Using the website as it currently is - just for new users.
Second test: Restore the website (database and files) to the state it was in when we began examining this issue, before any changes were made, and only incorporate the new 'MulticurrencyHooks' file.
I will report the results to you.
If everything goes well, I will consult with you about implementing the fix on the production site.
Once again, I truly appreciate your understanding and your support. The people are what make the product.
I will need a bit of time, but I promise to thoroughly check everything multiple times in the best way possible before responding.
Hi Guy,
I hope you're doing well. Sorry for the delay in responding due to the weekend and vacation.
Feel free to conduct tests and share your findings with us. Should you require additional support, we're here to assist.
I also wanted to mention that our development team is actively working on a more comprehensive fix for this issue. Rest assured, I will keep you updated on any progress.
I appreciate your patience and cooperation in this matter. Looking forward to your response.
After intensive testing, I found that this fix is solid. The calculation for switching subscriptions works perfectly in both languages (in our case, each language represents a different currency).
Before concluding, I will conduct one more test.
I am going to reset the test site and only use your new version of MulticurrencyHooks.php.
Thank you for the detailed update and for the thorough testing you've conducted. It's great to hear that the fix is performing well in both default languages. Please continue to keep us informed of your progress.
Looking forward to your response and we're always here to help!
We have gone through an interesting process together in which we clarified the issue and also provided a solution that works perfectly.
First of all, thank you very much for the understanding and for successfully resolving the issue. All the tests on the test site have been completed successfully.
For the development team, I will summarize the issue so they can provide a permanent solution and have a single place that clearly presents the issue.
Concepts:
Subscription Swap:
When adding the official WooCommerce Subscriptions plugin to WooCommerce, it is possible to create several subscriptions and then define them as one group, allowing the customer to switch between them. The way to define the products as a group is by creating a "grouped product."
Now, a customer who has purchased a subscription product can enter the "grouped product" and click on swap subscription to upgrade. The customer can also do this directly from their account area >> Subscription details. There, when displaying the subscription, there is an "Upgrade Subscription" button.
The Problem That Occurred
The site's multi-currency settings are as follows:
English language - USD currency
Hebrew language - ILS currency
The product was originally set up in Hebrew, and the main language of the site is English.
When the customer clicked on swapping the subscription, WPML failed in English to take the existing subscription's price in USD (even though USD is set only for English).
All other numbers were correct (the price of the new subscription).
Of course, the calculation of the difference was incorrect because the price taken was not in USD.
By the way, in Hebrew, which is the second language, it worked correctly.
The fix solved the problem, and now WPML on the English site successfully takes the price in USD as required.
It seems that the root of the problem is that the main language of the product is Hebrew and the USD currency was defined in the WPML translation. I assume that WPML simply did not check the currency for the language and just took the main currency from the product.
And this is precisely and only in the main language.
Because in the secondary language, a check was indeed made on what currency was defined in the multi-currency plugin.
Attached (txt files) is the original file MulticurrencyHooks.php hidden link
and also the new version you made that solved the problem. hidden link
To avoid any obstacle every time we need to update woocommerce-multilingual, it needs to be updated in your updated version of woocommerce-multilingual.
When can you implement this in the official update?
Again, thank you, Prosenjit, for the journey and the consistency. It gives a feeling of partnership in a way that is much more than technical support, but rather real business support.
P.S.
You will find another small fix in the new version that was also provided by your support.
This is a really small change that ensures the "Price From" (shown in grouped products) will be correct. The same for this bug - it was only for the USD currency.
If you can also include this very small but important fix, it would be a great help.
See the image "price_from_fix" to view the line changed.
First and foremost, Thank you so much for your kind words and the positive feedback on our collaborative process. It has been a truly rewarding journey to work through the challenges together, and I am immensely pleased to hear that the solution we shared has met your expectations and yielded successful results on the site.
I truly appreciate your willingness to share a detailed description of the issue with our development team. It contributes to our ongoing efforts to enhance our plugin. This kind of collaboration not only strengthens our partnership but also enriches our understanding and approach to resolving complex issues.
Since both the issues you reported are in our development queue, a permanent fix for both will be included in the future version of the WCML plugin. But, sorry to inform you that currently, I don't have an ETA for when the fixed version will be released. But, please rest assured that we are actively working on it. We understand the importance of this matter, and I assure you that you will be promptly informed as soon as we have any updates.
Once again, thank you for your trust, cooperation, and the constructive spirit in which we have navigated this situation. It is clients like you who make our work deeply fulfilling and drive us to continually strive for excellence.
If you have any further questions or need additional support, please do not hesitate to reach out. We'll be happy to help.
With every update of WCML, we need to invest special time. As of today, we have one update (fix) that we always need to modify in the file /woocommerce-multilingual/classes/Rest/Wrapper/Orders/Prices.php
The fix does not occur from the theme's function.php file, which makes it particularly challenging since, with every update, it's necessary to alter code within the plugin.
If it were possible to make fixes at the level of functions.php, we could update WCML just like we update other plugins.
Now, instead of one fix, we have three fixes.
This causes us to not upgrade the WCML plugin as frequently.
I don't know if there's anything you can do to help, but knowing you, it's worth bringing up the issue.
We always need toi check the file before the fix.it takes time.
I completely understand but, unfortunately, implementing these fixes via the functions.php file isn't possible at the moment due to dependencies within the plugin itself.
For now, I recommend keeping the version you currently have and reviewing the changelog before applying any updates to ensure that the custom changes remain saved.
Rest assured, I will notify you as soon as a version of the plugin that incorporates your needed fixes is available so that you don't need to update the changes manually. Thank you for your patience and understanding.
If there is anything else you need help with, feel free to let me know. I will be happy to help.
Best regards,
Prosenjit
The topic ‘[Closed] Split: Woo subscriptions wrong price’ is closed to new replies.
