[Escalated to WPML Developers team] Switching languages when there are items in the cart

Hi Marcel,

Ok all tests done.

Here some observations, doubts and issues:

1/ With the new php function the url after switching languages changes correctly.

2/ When changing language with products on the cart, notification only appears when the product is a bundle product (Image 1). For single products, no notification appear and the cart just get emptied automatically when changing language. Is that the normal behaviour? I think this notification of empty cart before switching language should appear always, no matter if this is a single/variable product or a bundle product.

This is the notification (Attached Image-1)
"Switching language?
You've switched the language and there are items in the cart. If you keep the Català language, the cart will be emptied and you will have to add the items again to the cart.
Keep Català | Switch back to Spanish"

3/ Following point 2 - when switching languages on bundle products, there is a "force_switch" function (action) that makes the cart to empty and the page gets clear on the new language.

e.g. url after switching language:
hidden link

Instead on single/variable products after the switch lanaguage is done automatically, a notification to add again the products on the cart gets on top of the cart and product pages and never disappears - it also gets duplicated over and over again. (Attached Image 2)

I believe that the "force_switch" action, clears all products and thus no notifications are appearing after this action?

Can you please check on the Staging site: hidden link
and let me know something.

Thanks and regards,
Xavier

Hi Marcel,
Thanks.

I don't need the fallback option - indeed I did not enable this option myself. Everything is fully translated. I've already changed to "Translatable".

When you say: "Our team will check a solution for that." what is the problem now that should be fixed?
I believe is that with the option of “Translatable – use translation if available or fallback to default language” enabled -> if translation is available should work as the "Translatable" option, but now seems it's not working correctly and falling back to the default language, no?

Let me know what will be the next steps. Is the team still checking for the solution?

Regards,
Xavier

ok, thanks.
Then, I look forward to your feedback when the solution is ready.

Regards,
Xavier

Hi Marcel,
I've realized that the solution you gave me for the issue where the url gets duplicated when switching languages and the cart has products on it, is just getting overwritten every time I update the WPML plugin.
This is a bit a pain in the ass, as I easily forget about that.

Are you planning to add this patch on future plugin updates? Or just keep it as a patch which force me to manually imput every time you release a new plugin update?

This is the patch that I'm currently using:

public function get_current_url() {
/* phpcs:ignore WordPress.CSRF.NonceVerification.NoNonceVerification, WordPress.VIP.SuperGlobalInputUsage.AccessDetected, WordPress.VIP.ValidatedSanitizedInput.InputNotValidated, WordPress.VIP.ValidatedSanitizedInput.MissingUnslash */

$scheme = is_ssl() ? 'https' : 'http';
$host = $_SERVER['HTTP_HOST'] ?? parse_url( home_url(), PHP_URL_HOST );
$uri = $_SERVER['REQUEST_URI'] ?? '/'; // already includes the query string if present
return esc_url_raw( $scheme . '://' . $host . $uri );
}

Hi Marcel,

But the functional workaround disappear every time I update WPML plugin.
How come this can be a workaround? A workaround is when there is no need to imput manually again the patch code every time the plugin is updated.

Is there any solution to avoid that the patch to be reinserted on each plugin update?

Regards,
X

HI Marcel,
Thanks.

But in this case, this is a WPML bug, so this temporarily workaround, while it's totally fine, I don't understand why cannot be included in the next update? If I should wait for other customers to face the same problem, I can be holding forever...

One more thing. As I think is all related to the same issue.

I've realized that on the translated language, the "Thank You" page at the final step of a purchase, the order details does not appear on the screen. The order works and has been sent correctly but no order details are retrieved on this page.
I've attached 2 images:
Original Language (Catalan): order details appear correctly
Secondary Language (Spanish): order details are missing

If I disable WCML and String translation plugins, it seems it works. It uses the Catalan slug of "completed order" but retrieves the details in Spanish - even the page design is different from the original language.

Have serveral customers complaining as they're not sure if the order has been correctly done. If you can please have a look and see what can be the issue.

Website to test:
hidden link
You have all details to access it.

Regards,
Xavier