 Andreas W.
WPML Supporter since 12/2018
Languages:
English (English )
Spanish (Español )
German (Deutsch )
Timezone:
America/Lima (GMT-05:00)
|
Ok, let's wait for their reply. Maybe it might be something that they already cover if you purchase the PRO version.
|
 alexZ-17
|
1 Congratulations! Your proposal is accepted:
„
Hi,
Thanks for sharing the code with us. We will forward it to the development team and include it in future versions of the plugin.
We appreciate your help and cooperation.
Thank you.
--
Pulak Ahmed
support@shapedplugin.com
„
If you don’t oppose, I would suggest I inform Amit (support.manager@onthegosystems.com) about it, because it is not only a proof of your professional level, but also the sign of importance of WPML in the WP community.
2 Due to the fact that I am unsure if my skills would be enough to implement your general workflow – even if you support me – maybe it is simpler that I update wp-content\plugins\wp-carousel-free\public\WPCF_Helper.php locally. It could be probably better if ShapedPlugin tests for side effects, but due the experience with you I assume the risks are minimal – and naturally are on my side.
What is your opinion?
thx
|
 Andreas W.
WPML Supporter since 12/2018
Languages:
English (English )
Spanish (Español )
German (Deutsch )
Timezone:
America/Lima (GMT-05:00)
|
The compatilbity team provided a new workaround, that is simpler and solves the issue, too:
wp-content\plugins\wp-carousel-free\public\WPCF_Helper.php
Look for line 258
Replace:
[php]
foreach ( $attachments as $attachment ) {
require self::wpcf_locate_template( 'loop/image-type.php' );
} // End foreach.
With:
foreach ( $attachments as $attachment ) {
// WPML Workaround for compsupp-7940
$current_lang = apply_filters( 'wpml_current_language', NULL );
$attachment = apply_filters( 'wpml_object_id', $attachment, 'attachment', TRUE, $current_lang );
require self::wpcf_locate_template( 'loop/image-type.php' );
} // End foreach.
This will translate the original media ID. No need to translate the carousel or its meta-fields. You can translate meta-fields from the IMG (alt, title, description) directly in the media library.
If you would like my assistance with implementing this change, please let me know.
|
 alexZ-17
|
Everything works fine.
Thanks a lot.
Should I forward the simpler code to ShapedPlugin?
Best regards
|
 Andreas W.
WPML Supporter since 12/2018
Languages:
English (English )
Spanish (Español )
German (Deutsch )
Timezone:
America/Lima (GMT-05:00)
|
Yes, please report the issue to the author for further feedback.
It is yet unclear to me at this point if this is something they cover in their PRO version.
|
alexZ-17 |
It seems yesterday it was a blackout at WPML – translations not available, support -dead.
I have not understood it at first and looked for a failure on my side, and have found something strange – on some pages languages are mixed.
I could imagine that if translation is in progress, it could be a case.
But I enclose the page where no translation is in progress and I am sure the page was in order - English text is red-circled.
Have you any idea?
Should I open a new thread?
Basic question: if a page is translated is the website dependent on WPML servers?
|
 Andreas W.
WPML Supporter since 12/2018
Languages:
English (English )
Spanish (Español )
German (Deutsch )
Timezone:
America/Lima (GMT-05:00)
|
My apologies, but we can only handle one issue per ticket.
I am splitting your last comment into a new ticket and will follow up with you from there.
Can you please confirm if the issue that we handled on this ticket could be clarified with ShapedPlugin LLC?
|
 alexZ-17
|
I have forwarded the second version to ShapedPlugin - but they are on holydays and will contact me in time due.
Can we close this thread?
|
 Andreas W.
WPML Supporter since 12/2018
Languages:
English (English )
Spanish (Español )
German (Deutsch )
Timezone:
America/Lima (GMT-05:00)
|
Let's close for now and wait for the feedback of ShapedPlugin.
In case further assistance regarding this issue is needed from our side, please let us know.
|
 alexZ-17
|
great support from Andreas and compatibility team
|