Ok I do understand now. They need query string all the time in the URL.
But your above code has so many flaws.
1. The code is setting both session and cookie.
2. Cookie name is incorrect "client_currency_cookie" this should be "wcml_client_currency"
3. You are checking if currency is valid against woocommce currency that mean even if the currency does not exist in WCML multicurrency that can be set in cookie.
4. Again in 2nd hook "wcml_switch_currency" we are setting the same cookie and session while none of them is needed.
Now this code will not change the currency based on the parameter as I stated before but will change the parameter based on currency change from swticher.
To fix this we can add this code which I modified.
add_filter('wcml_client_currency', 'modify_client_currency', 10, 1);
function modify_client_currency($current_currency) {
if (!is_admin() && !empty($_GET['wcmlc'])) { //Check if not admin and wcmlc parameter exist.
global $woocommerce_wpml;
$currency = strtoupper(esc_attr($_GET['wcmlc'])); //Make in uppercase and escape the bad values.
if (array_key_exists($currency, (array) $woocommerce_wpml->settings['currency_options'])) {
// Check if currency exists in WCML settings and reutrn.
return $currency;
}
}
return $current_currency; //Return the original currency if nothing matches.
}
I have added comments in code so you can understand what is happening.
Now if a request come we will change the currency based on parameter and cookie will be set by WCML based on currency change.
We don't need session so there will be no change in session data.
We are checking value from URL against the WCML setting so no other currency can be set apart from currencies define in WCML settings.
1. can we change your code to be ?currency instead of ?wcmlc
so we won't loose the seo traffic?
2. we were using client_currency_cookie as marker for the currency, before wpml had their own cookie strategy, so you are right we don't need it anymore
3. wpml currency will be stored in wcml_client_currency, am i correct?
* asking the above, so we can test with or without caching that cookie
1. can we change your code to be ?currency instead of ?wcmlc
so we won't loose the seo traffic?
I would not suggest changing in core files. Instead I would suggest a redirect from currency to wcmlc.
Your dev can easily write a simple redirect code to change this query string. With the 301 redirect Google will update the URLs.
3. wpml currency will be stored in wcml_client_currency, am i correct?
* asking the above, so we can test with or without caching that cookie
Yes the new cookie name will be "wcml_client_currency".
but site still not cached - can you take a pick please at things you see different in
As I can see both of the URLs are not cached. I am testing by seeing the page source and the time at the bottom it always changes with each refresh. Please see the screenshot
For this issue, I am really not sure what is wrong. Maybe LiteSpeed can help?
I have suggested changes based on their suggestion. Did you contact them? What they are saying now?
i am speaking to them constantly this morning (before this morning they were not available for 2 days)
we upgraded to litespeed 6.1 this morning, since they updated something related to WCML
this file: hidden link
they suggested we add in line 16
"in this file , after line 16 , add
return;
this will stop plugin to set cookie vary , see how it goes
so now we are seeing cache hit hidden link
while i think its a progress, i find it facinating that litespeed can't cache the cookie of
wcml_client_currency an wcml_client_language
and lastly, we have seen this behaviour on hebrew pages before we moved to cookie strategy, when you entered hebrew product page, you didn't have any cookie downloaded so it was a cache hit
and now all product pages don't have cookie on first entrance, so they are cache hit as well
I don't know, how do you determine if the cache was hit or not but I see none of the pages is cached based on the time stamp in source code of the page.
About the cookie, I see it is properly set in the response header for the first request. Please see the attached screenshot.
I think this is something from LiteSpeed, why none of the pages are cached, they should fix it.
OK their are several ways you can check if its cached
1. open incognito , open dev tools, go to this url - hidden link
A. it loads in 1 second = CACHE
B. dev tools - look in the document headers, you will see "X-Litespeed-Cache:hit"
SECONDLY, now that the site is cached again finally, i can tell you what this meant
"hidden link
they suggested we add in line 16
"in this file , after line 16 , add
return;"
this means litespeed now bypassed their integration with WCML, and since the site is cached, is not known that litespeed has issues with WCML, that they plan to work on.
but its cached due to the fact that we basically cache per URL.
i hope they introduce a fix so everyone can have it cached.
what i know that up to version 5.8 of litespeed, and wpml 4.68 things worked well
I thank you for being patient and providing a solution - any update re-when you will release the category indexing on version 4.7? so we can close this ticket?
Could you provide ticket about category indexing issue? So I can share the exact details.
WPML 4.7 is a major release it is not just WPML we will be adding more features to the entire system.
We may release it next month if everything goes as planned. But please share the ticket details we reschedule tickets based on the severity so something may have been released already.
Yes, this is a known ticket to me. Most of the issues required for this are fixed and waiting for release.
If there will be a beta we will let you know the same ticket that is still open.
