[Resolved] You can only edit translations assigned to you.

Hello,

I have identified the problem. As mentioned earlier, the issue began after upgrading from version 4.6.3 to 4.6.11.

The problem lies in the function has_user_rights_to_translate($trid, $lang) within class-wpml-tm-translation-status-display.php. This function should permit editing if User::isAdministrator($user) || User::isEditor($user).

The user in question is not an Administrator but is definitely an Editor. However, isEditor is returning false.

It appears that WPML is checking if the user is an Editor not by their actual roles, but by a minimum set of capabilities defined in User.php:

public static function isEditor( \WP_User $user = null ) {
foreach ( static::ROLE_EDITOR_MINIMUM_CAPS as $cap ) {
if ( ! self::hasCap( $cap, $user ) ) {
return false;
}
}
return true;
}

The constant ROLE_EDITOR_MINIMUM_CAPS is defined as:

const ROLE_EDITOR_MINIMUM_CAPS = [
self::CAP_EDIT_OTHERS_POSTS,
self::CAP_PUBLISH_PAGES,
self::CAP_PUBLISH_POSTS,
self::CAP_EDIT_PAGES,
self::CAP_EDIT_POSTS,
];

Our Editors do not satisfy these capabilities. They have always their capabilities modified that allow them to edit a CPT rather than a regular Post. It also allows them to edit other users' post types of this CPT. Also, we do not permit Editors to modify Pages.

I confirm that has_user_rights_to_translate was introduced after version 4.6.3. I have downloaded the code for 4.6.3 and this check was not there.

I kindly request you to reconsider the logic of checking if User::isEditor based on ROLE_EDITOR_MINIMUM_CAPS.

There may be cases where an Editor needs to have some capabilities removed for security reasons, which WPML now requires as "minimum" to consider them an Editor.

In your changelog for Version 4.6.7 I see:

"Enhanced the capabilities for editors with correct language pairs so they can access translation that is translated by a different translator."

This change may have been the source of the problem.

Thank you.

Reuben

Dear Nicolas,

Thank you for the update.

What would be the best way for us to remain updated on this update?

Reuben