[Resolved] wpml latest 4.6.9 + litespeed issue

hey goo old friend - sumit,

i saw what bigul wrote to me the other day in
https://wpml.org/forums/topic/wpml-latest-4-6-9-litespeed-issue/page/3/#post-15336379

we are in process of change our code:
https://wpml.org/forums/topic/wpml-latest-4-6-9-litespeed-issue/page/3/#post-15338335

to have cookie instead of session implementation, however that doesn't resolve the whole thing

as WPML discussed recently with litespeed - but you wasn't involved, because i am sure if it is was you, you would have not closed the discussion - if you will see the guy who spoke on the below thread is litespeed team member, their LAST and MAIN issue is that the URL is not changing:
https://wpml.org/forums/topic/anyway-to-force-show-up-the-currency-query-string-in-every-page/

i am also trying from our end, and my dev, built this, tell me what you think, this changes currency and URL, and we still use sessions at the moment

function wprdcv_param_redirect(){
$current_currency = apply_filters('wcml_price_currency', NULL);
if(isset($_COOKIE['client_currency_cookie']) && (!$_GET['currency'] || $_GET['currency']!=$current_currency)){
$location = esc_url(add_query_arg('currency', $_COOKIE['client_currency_cookie']));
wp_redirect($location);
}
}
add_action('template_redirect', 'wprdcv_param_redirect');

Ruikai and Eric are the team leads in Litespeed for solving issues.

I gave them yesterday our manual code, because they told me, they need redirect, since they plan to cache URLs, and they are not ok, even with cookie feature, to have the same URL with different cookie

function wprdcv_param_redirect(){
$current_currency = apply_filters('wcml_price_currency', NULL);
if(isset($_COOKIE['client_currency_cookie']) && (!$_GET['currency'] || $_GET['currency']!=$current_currency)){
$location = esc_url(add_query_arg('currency', $_COOKIE['client_currency_cookie']));
wp_redirect($location);
}
}
add_action('template_redirect', 'wprdcv_param_redirect');

LASTLY, we do plan to also change from session to cookie, as you wrote, we just wait for final GO from litespeed all the setup works.

// Use Cookie instead of WCSession
add_filter( 'wcml_user_store_strategy', function ( $strategy, $key ) {
return 'cookie';
}, 10, 2 );
add_filter( 'wcml_is_cache_enabled_for_switching_currency', '__return_true' );

"When adding a redirect code also adjust the links on the site using javascript so when the user comes with a query string there will be no redirect this way you can save extra request to server."

what do you mean, users already have links like:
hidden link

and it works

we are only adding when the user changes currency

function wprdcv_param_redirect(){
$current_currency = apply_filters('wcml_price_currency', NULL);
if(isset($_COOKIE['client_currency_cookie']) && (!$_GET['currency'] || $_GET['currency']!=$current_currency)){
$location = esc_url(add_query_arg('currency', $_COOKIE['client_currency_cookie']));
wp_redirect($location);
}
}
add_action('template_redirect', 'wprdcv_param_redirect');

Hi Sumit - I need your help

Litespeed disapeared, he told me he was going to China for a trip, but then disappeared for several days (maybe no internet connection)

in POST - https://wpml.org/forums/topic/wpml-latest-4-6-9-litespeed-issue/page/3/#post-15345729

i asked, what should my htaccess look like, in order to get litespeed to cache the cookie,

do you have any idea on that to help?

hi sumit,

i need your input please

eventually we decided not to use

function wprdcv_param_redirect(){
$current_currency = apply_filters('wcml_price_currency', NULL);
if(isset($_COOKIE['client_currency_cookie']) && (!$_GET['currency'] || $_GET['currency']!=$current_currency)){
$location = esc_url(add_query_arg('currency', $_COOKIE['client_currency_cookie']));
wp_redirect($location);
}
}
add_action('template_redirect', 'wprdcv_param_redirect');

instead we edited

woocommerce-multilingual/res/js/wcml-multi-currency.js
real name of file was wcml-multi-currency.js I added -123 to neglect caching of file.
I added new code from line # 54 to line #58
if (target_location.indexOf('currency=') === -1) {
target_location += '?currency=' + currency;
} else {
target_location = target_location.replace(/([?&])currency=[^&]+/, '$1currency=' + currency);
}

now for the question, you gave us a code to implement so wcml works based on cookies and not based on session

// Use Cookie instead of WCSession
add_filter( 'wcml_user_store_strategy', function ( $strategy, $key ) {
return 'cookie';
}, 10, 2 );
add_filter( 'wcml_is_cache_enabled_for_switching_currency', '__return_true' );

then you told us not to use
add_filter( 'wcml_is_cache_enabled_for_switching_currency', '__return_true' );

in case we edit the js like we showed you above, do we need to keep
add_filter( 'wcml_is_cache_enabled_for_switching_currency', '__return_true' );

in our snippet of wcml changing to cookie or not?

Hi Sumit,

we tried your code either as

// Use Cookie instead of WCSession
add_filter( 'wcml_user_store_strategy', function ( $strategy, $key ) {
return 'cookie';
}, 10, 2 );

or as

// Use Cookie instead of WCSession
add_filter( 'wcml_user_store_strategy', function ( $strategy, $key ) {
return 'cookie';
}, 10, 2 );
add_filter( 'wcml_is_cache_enabled_for_switching_currency', '__return_true' );

and in both cases, when we did
hidden link

we got USD currency, so that means something is not working on your code

so we returned to using sessions for now, and now ?currency=ZAR or ?currency=CAD is working

add_filter( 'wcml_client_currency', 'modify_client_currency', 10, 1 );

function modify_client_currency( $current_currency ) {
if( !is_admin() ){
global $woocommerce;

if(isset($_GET['currency']) && !isset($_COOKIE['client_currency_cookie'])){
$currency = esc_attr( $_GET['currency'] );
$currency = strtoupper( $currency );
$currencies = get_woocommerce_currencies();
if ( array_key_exists($currency, $currencies)) {
if ( ! $woocommerce->session->has_session() ) {
$woocommerce->session->set_customer_session_cookie( true );
$woocommerce->session->set( 'client_currency', $currency );
} else {
$woocommerce->session->set( 'client_currency', $currency );
}
setcookie( "client_currency_cookie", $currency, 0, '/' );
} else {
return $current_currency;
}
}else{
if(isset($_COOKIE['client_currency_cookie'])){
$currency = $_COOKIE['client_currency_cookie'];
}else{
$currency = $current_currency;
}
}
return $currency;
}
}

add_action( 'wcml_switch_currency', 'my_custom_action_kideno', 10, 1 );
function my_custom_action_kideno( $new_currency ) {
global $woocommerce;
if ( !$woocommerce->session->has_session() ) {
$woocommerce->session->set_customer_session_cookie(true);
$woocommerce->session->set('client_currency', $new_currency);
}else{
$woocommerce->session->set('client_currency', $new_currency);
}
setcookie("client_currency_cookie", $new_currency,0,'/');
}

maybe you can shed some light on this topic

this is being cached perfecly
hidden link

my guess is it because it doesn't have multiple currencies so no client_currency_cookie is being downloaded at first

this however doesn't gets cached anymore
hidden link

what you see in dev console is that their is issue with client_currency_cookie, so their are several ways

1. get litespeed to develop special module for wpml/wcml session cookie

2. you manage to get the cookie strategy to work with ?currency=XXX, this way they will cache it per url and then they told me we won't need cookie-vary directive in htaccess