to have cookie instead of session implementation, however that doesn't resolve the whole thing
as WPML discussed recently with litespeed - but you wasn't involved, because i am sure if it is was you, you would have not closed the discussion - if you will see the guy who spoke on the below thread is litespeed team member, their LAST and MAIN issue is that the URL is not changing: https://wpml.org/forums/topic/anyway-to-force-show-up-the-currency-query-string-in-every-page/
i am also trying from our end, and my dev, built this, tell me what you think, this changes currency and URL, and we still use sessions at the moment
We don't need any custom code this was the feature of WCML to add query string with currency in URL but in a later version, we switched to the session then we got issues related to caching so we introduced a new feature in the form of filter "wcml_is_cache_enabled_for_switching_currency".
We have missed documenting this filter so this may be the reason our team did not find it.
However, this filter is our recommended way to add a query string.
The code you wrote may work but we must not go to the complicated (redirecting user each time causing double request to server) way we should choose the easy way 🙂 Adding a filter will do the job. When last time we interacted you had a staging site so if you still have this, I would say to add these filters there and check you will have a query string in the URL when currency changes.
Apart from that LiteSpeed doesn't need to open a new ticket for their question they can directly reach our compatibility team. Please let them know this, they must have our email address because we interacted with them in the past.
The person's name was "Ruikai" as I can see from the records.
Ruikai and Eric are the team leads in Litespeed for solving issues.
I gave them yesterday our manual code, because they told me, they need redirect, since they plan to cache URLs, and they are not ok, even with cookie feature, to have the same URL with different cookie
This is not needed and will cause interference with your query string and WCML query string.
The only code you need is
// Use Cookie instead of WCSession
add_filter( 'wcml_user_store_strategy', function ( $strategy, $key ) {
return 'cookie';
}, 10, 2 );
To enable cookies.
I hope for now you don't need any further help from my side. But I will keep this ticket open for a while and you can reply if you need any further help.
Other suggestions, not related to WCML but for your site. When adding a redirect code also adjust the links on the site using javascript so when the user comes with a query string there will be no redirect this way you can save extra request to server.
"When adding a redirect code also adjust the links on the site using javascript so when the user comes with a query string there will be no redirect this way you can save extra request to server."
what do you mean, users already have links like: hidden link
Yes I understand but suppose the currency is USD and the cookie is also USD and the parameter does not exist in the URL then it will redirect, so if someone visits hidden link it will redirected to hidden link this is what I meant.
However, I see no redirect on your website yet it seems code is not added yet. Please finalize the solution from LiteSpeed and if anything needed from WPML side let me know.
Okay! As we agreed you will be using WCML cookie and your code for the query string so only the cookie name will be changed. And the cookie WCML stores is "wcml_client_currency"
Based on that only this code will be changed from "client_currency_cookie" to "wcml_client_currency" so that will be
woocommerce-multilingual/res/js/wcml-multi-currency.js
real name of file was wcml-multi-currency.js I added -123 to neglect caching of file.
I added new code from line # 54 to line #58
if (target_location.indexOf('currency=') === -1) {
target_location += '?currency=' + currency;
} else {
target_location = target_location.replace(/([?&])currency=[^&]+/, '$1currency=' + currency);
}
now for the question, you gave us a code to implement so wcml works based on cookies and not based on session
// Use Cookie instead of WCSession
add_filter( 'wcml_user_store_strategy', function ( $strategy, $key ) {
return 'cookie';
}, 10, 2 );
add_filter( 'wcml_is_cache_enabled_for_switching_currency', '__return_true' );
then you told us not to use
add_filter( 'wcml_is_cache_enabled_for_switching_currency', '__return_true' );
in case we edit the js like we showed you above, do we need to keep
add_filter( 'wcml_is_cache_enabled_for_switching_currency', '__return_true' );
First of all, I would not advise you to change the files of WCML as this will prevent you from updating the plugin.
Second, the file you are changing is not even loaded on production the correct file is wp-content\plugins\woocommerce-multilingual\res\js\multi-currency.min.js
This file is loaded only when SCRIPT_DEBUG is set to true. This is not advisable to set this true on production.
Now coming to your question
in case we edit the js like we showed you above, do we need to keep
add_filter( 'wcml_is_cache_enabled_for_switching_currency', '__return_true' );
No, you don't need to because you are manually adding the currency query string in the core file. This code only adds the query string when currency changes so it is not needed.
My best advice would be to use both the filters and avoid any changes also your changes and custom code.
This way we can keep the neat and clean customization without losing the updates.
If you add these both filters all of your work is done
// Use Cookie instead of WCSession
add_filter( 'wcml_user_store_strategy', function ( $strategy, $key ) {
return 'cookie';
}, 10, 2 );
add_filter( 'wcml_is_cache_enabled_for_switching_currency', '__return_true' );
Now if the user goes to next page e.g. from the product page where he switched the currency to the shop page the query string will be removed. This thing we need to confirm with LiteSpeed if they still need to query string all the time or if it is just needed for once when currency is changed.
Most of the Cache plugin needs it only once and they reset the cache based on that. That's why we introduced this feature.
In case they need query string all the time then we need to work in this direction.
Do you agree?
PS:- I am bound not to recommend any customization in core files those are not a workaround but for customization. So I am truly sorry I can not assist you in that direction.
Our hook does not work like that. It does not change the currency from URL query string value but URL query string value changes based on the currency.
For example, on your site change the currency using currency switcher and you will see the URL value changed on the currency change request.
This is what is needed for caching plugin to work as per our understanding.
To fix this issue faster I would suggest asking LiteSpeed support exactly what is needed in WCML to make this work. Then only I can suggest to you what we can do.
for now, I am not understanding what is needed from the LiteSpeed cache, is it a cookie, query string etc.
my guess is it because it doesn't have multiple currencies so no client_currency_cookie is being downloaded at first
this however doesn't gets cached anymore hidden link
what you see in dev console is that their is issue with client_currency_cookie, so their are several ways
1. get litespeed to develop special module for wpml/wcml session cookie
2. you manage to get the cookie strategy to work with ?currency=XXX, this way they will cache it per url and then they told me we won't need cookie-vary directive in htaccess
louisN-4 confirmed that the issue was resolved on 2024-03-20 12:12:05.
This ticket is now closed. If you're a WPML client and need related help, please open a new support ticket.
