[Resolved] Only one Woocommerce Booking reminder is being sent by Cron
This thread is resolved. Here is a description of the problem and solution.
Problem: Since WooCommerce Multilingual & Multicurrency 5.3, a bug prevents multiple WooCommerce Bookings reminders scheduled at the same time from being sent. Only the first reminder is sent due to the
sendWithoutDuplicates()
function in
woocommerce-multilingual/WcBookings/Emails.php
, which disables
woocommerce->mailer()
after the first email is sent, assuming no other emails need to be sent afterward.
Solution: We have included a fix for this issue in our latest update. Please ensure you have tested the package to confirm the resolution. If you are still experiencing issues or the solution provided here does not resolve your problem, we recommend checking related known issues at https://wpml.org/known-issues/, verifying the version of the permanent fix, and confirming that you have installed the latest versions of themes and plugins.
If the problem persists, please do not hesitate to open a new support ticket for further assistance. You can do so at WPML support forum.
This is the technical support forum for WPML - the multilingual WordPress plugin.
Everyone can read, but only WPML clients can post here. WPML team is replying on the forum 6 days per week, 22 hours per day.
Since WooCommerce Multilingual & Multicurrency 5.3, a bug prevents multiple Woocommerce Bookings reminders scheduled at the exact same time to be sent (only the first one is sent).
If a (or several) booking product(s) allow(s) for multiple bookings at the exact same time, scheduled wc-booking-reminder WP Cron events will fail silently (with no error/log) after the first reminder is sent.
This is due to public function sendWithoutDuplicates( $bookingId, $class ) in woocommerce-multilingual/WcBookings/Emails.php disabling woocommerce->mailer() after the first email is sent:
$emailObject->enabled = 'no';
Disabling entirely woocommerce->mailer() to prevent duplicates is a bit brutal / assumes no other emails have to be sent afterward.
Since multiple wc-booking-reminder WP Cron events scheduled a the same time are processed in the same request, additional reminders are not sent.
I've temporarily patched this bug using this (rather inelegant) fix:
/**
* @param string $emailClass
*
* @return \WC_Email|null
*/
private function getEmailObject( $emailClass ) {
// Fix multiple emails not sent in cron
$emailObject = Maybe::of( $emailClass )
->map( Obj::path( [ 'emails', Fns::__ ], $this->woocommerce->mailer() ) )
->getOrElse( null );
if($emailObject->enabled == 'no'){ // has been disabled after first $emailObject->trigger in sendWithoutDuplicates
$emailObject->enabled = 'yes';
}
return $emailObject;
/* return Maybe::of( $emailClass )
->map( Obj::path( [ 'emails', Fns::__ ], $mailer ) )
->getOrElse( null );
*/
}
Could you check this bug and patch sendWithoutDuplicates(), using a better way to handle duplicates (without disabling woocommerce->mailer() )?
To send the ticket to the compatibility team I need to have the issue reproduced on a Sandbox or on a staging site. I see you're using a staging, would it be possible to have a copy and/or access to the site?
Otherwise I can set up a Sandbox for this. Thanks.
Hello Laura,
We do not have a staging website we can give you access to.
If you create a sandbox, you can reproduce the bug like this:
- install WordPress+Woocommerce+Woocommerce Bookings+WPML+Woocommerce Multilingual
- Create a bookable product with more than 1 booking allowed per slot
- book the same slot several times (at a time late enougth so that wc-booking-reminder are schedules, not sent right away)
- you'll see the wc-booking-reminder WP Cron events being scheduled (24h before start time by default) and you'll see all event but the first one not being sent
You may also share my initial message as is with the compatibility team: the bug present in public function sendWithoutDuplicates( $bookingId, $class ) is easy to spot (once you're there): they'll see/understand the issue right away.
I tried to reproduce the issue here hidden link but I don't see any email sent, not even when I try to send a notification to Bookings > Send notification
(you won't receive any mail but I can still see which mails are being sent by WordPress)
The two orders placed had the "Processing" status (waiting for payment upon delivery) and thus bookings were not confirmed.
I recommend you do not use the COD gateway to test (or that you manually mark orders as completed).
I took the liberty of installing "Log Emails" and "WP Control" (now available in Tools/Log Emails and Tools/Cron Event).
You'll see scheduled cron events (search for wc-booking-reminder) and emails sent.
Five are scheduled as I write this (see attached screenshot)
In order to test reminder emails sent by cron, you'll have to enable CRON on the sandbox (currently disabled: The DISABLE_WP_CRON constant is set to true.)
When you do, you'll likely notice that a reminder is sent, but the others aren't.
Disabling all WPML plugins lets all emails being sent properly. Maybe using the same account/email to create bookings leads to receiving only one notification?
Could you double-check:
- disable all WPML plugins
- create two orders and bookings at the same time/date (with different users or using guest checkout with different emails)
- mark the orders as complete
- see that both reminders are properly sent
I created bookings #127 and #131. Both emails were successfully scheduled and sent (see attached screenshots).
This is a WPML-specific bug: sendWithoutDuplicates( $bookingId, $class ) in woocommerce-multilingual/WcBookings/Emails.php
(details in my the initial post)
2nd tier thinks you're right, but they can't reproduce the issue in the Sandbox. Could you maybe provide us a video so we can check if we're missing something?
You guys had already properly created bookings (with reminders pending in 4 days).
I changed their schedule so that it happens while recording: hidden link
You'll see that they both trigger at the same time (video above) and then only the first email is sent (screenshot)
Unfortunately, fixing issues related to WooCommerce emails is not fixed, because the patch could create issues somewhere else, therefore it needs to be tested carefully - it's not trivial as it may seems.
I see the issue is tentatively scheduled for WCML 5.5, but we can't guarantee an ETA.
