[Waiting for user confirmation] Can't see Learndash courses in english

Issue 1: Courses slug is rewritten to prodotto" or "products":

On the staging that I disabled any plugin apart from Learndash and its addons, WooCommerce, SCF, Yoast and WPML and our addons.

The issue disappeared and I was for example able to access an Italian course here:
hidden link

The issue with the slug rewrite to "prodotto" or "product" does not occur again after I enable all the plugins again which is why I can not tell what was causing it.

---

Issue 2: Courses in second language us a wrong slug and display the error TO MANY REDIRECTS:

Once I switch from Astra Child Theme to the Astra Parent Theme the issue disappears.

This issue is caused by code inside your child theme's functions.php file.

I am fully sure what is causing this issue, but it seems to be connected to your custom integration of "Advanced Coupons for WooCommerce" in your Child Theme.

As the issue does not occur using the Parent Theme, this might need to be considered as an issue that occurs due to custom code.

If I comment out this line, the issue even occurs on the original course pages:
// use ACFWF\Models\Third_Party_Integrations\WPML_Support;

This might be something that you need to report to "Advanced Coupons for WooCommerce".

In case you need further assistance regarding this from our site, please explain to me why you are integrating the plugin in this way into the functions.php file of your Child Theme and what you are trying to achieve this way.

The first issue was just related to the slug rewrite, not to CPTs not visible on Frontend. The only workaround I found was setting the site into a minimal setup as explained above and then re-activiating all plugins again.

I wish I could provide you a better workaround for the first issue, but I sadly did not find one. Usually resaving the permalinks in WordPress should have been enough, but not in this case.

For the second issue, please tkae note that our support team is not supposed to troubleshoot custom code issue. I am making an exception in this case.

I have removed the plugin and its related code and relative files from the Child Theme. Take note, that this was not the source of the issue.

Current functions.php file:

<?php
// Exit if accessed directly
if ( !defined( 'ABSPATH' ) ) exit;

// BEGIN ENQUEUE PARENT ACTION
function gimarbeauty_script() {
    wp_enqueue_style( 'gimarbeauty', get_stylesheet_directory_uri() . 'https://cdn.wpml.org/style.css', array(), wp_get_theme()->Version );
}
add_action( 'wp_enqueue_scripts', 'gimarbeauty_script', 10 );

/* REWRITE RULES FOR SEO BY DAVIDE */
function gimarbeauty_corsi_generating_rule($wp_rewrite) {
    $rules = array();
    $terms = get_terms( array(
        'taxonomy' => 'ld_course_category',
        'hide_empty' => false,
    ) );

    $post_type = 'sfwd-courses';

    foreach ($terms as $term) {    
        $rules['i-nostri-corsi/' . $term->slug . '/([^/]*)$'] = 'index.php?post_type=' . $post_type . '&sfwd-courses=$matches[1]&name=$matches[1]';
    }

    // Merge with global rules
    $wp_rewrite->rules = $rules + $wp_rewrite->rules;
}
add_filter('generate_rewrite_rules', 'gimarbeauty_corsi_generating_rule');

function change_link_corsi( $permalink, $post ) {
    if( $post->post_type == 'sfwd-courses' ) {
        $resource_terms = get_the_terms( $post, 'ld_course_category' );
        $term_slug = '';
        if( ! empty( $resource_terms ) ) {
            foreach ( $resource_terms as $term ) {
                // Skip the 'featured' category to get the main one
                if( $term->slug == 'featured' ) {
                    continue;
                }
                $term_slug = $term->slug;
                break;
            }
        }
        $permalink = get_home_url() . "/i-nostri-corsi/" . $term_slug . '/' . $post->post_name;
    }
    return $permalink;
}
add_filter('post_type_link', "change_link_corsi", 10, 2);

Take note that this code includes:

- A function for enqueuing the parent theme’s stylesheet (gimarbeauty_script)
- Custom rewrite rules for SEO (gimarbeauty_corsi_generating_rule)
- A custom link modification function for course post types (change_link_corsi).

If you now go to hidden link you will still get a TOO MANY REDIRECTS error.

This errors appears to disappear if I disable WPML. I was not able to find a workaround for this and would suggest removing this function.

Take note, that I got stuck testing, as my edits on functions.php seem to have casued a syntax error and I can not access the file manager anymore.

Please remove the last function from the functions.php file of the Child Theme and it should solve the issue.

It is a conflict between WPML and the following function:

function change_link_corsi( $permalink, $post ) {
    if( $post->post_type == 'sfwd-courses' ) {
        $resource_terms = get_the_terms( $post, 'ld_course_category' );
        $term_slug = '';
        if( ! empty( $resource_terms ) ) {
            foreach ( $resource_terms as $term ) {
                // Skip the 'featured' category to get the main one
                if( $term->slug == 'featured' ) {
                    continue;
                }
                $term_slug = $term->slug;
                break;
            }
        }
        $permalink = get_home_url() . "/i-nostri-corsi/" . $term_slug . '/' . $post->post_name;
    }
    return $permalink;
}
add_filter('post_type_link', "change_link_corsi", 10, 2);

If I remove the function, the site operates as expected.

The way how this function is designed, it will always set the custom post type slug to "/i-nostri-corsi/" and this causes a conflict, if the slug is translated into something else in a second language.

My suggested fix will check for the slug in a second language and replace it accordingly. It will use the WPML Hook 'wpml_get_translated_slug' for this purpose.

I might a slight adjustment to the earlier provided function, as it was adding one "/" too much. In this case the custom function will get the expected URLs in both languages. Take note that I also translated the slug back to "courses" inside the WPML settings page:

function change_link_corsi( $permalink, $post ) {
    if( $post->post_type == 'sfwd-courses' ) {
        $resource_terms = get_the_terms( $post, 'ld_course_category' );
        $term_slug = '';
        
        // Retrieve the translated slug for the custom post type
        $language_code = apply_filters( 'wpml_current_language', NULL ); // Get the current language code
        $default_slug = 'i-nostri-corsi'; // Default slug in your primary language
        $translated_slug = apply_filters( 'wpml_get_translated_slug', $default_slug, 'sfwd-courses', $language_code, 'post' );

        if( ! empty( $resource_terms ) ) {
            foreach ( $resource_terms as $term ) {
                // Skip the 'featured' category to get the main one
                if( $term->slug == 'featured' ) {
                    continue;
                }
                $term_slug = $term->slug;
                break;
            }
        }

        // Build the permalink with the translated slug
        $permalink = trailingslashit(get_home_url()) . $translated_slug . '/' . $term_slug . $post->post_name;
    }
    return $permalink;
}
add_filter('post_type_link', "change_link_corsi", 10, 2);

This appears to solve the issue.

Please take kindly note again, that our supporters usually are not supposed to provide any custom code solutions and I made an exception here.

This is a developer topic and in such case you usally should reach out to one of our contractors:
https://wpml.org/contractors/

Yes, this is implemented on your staging site and can be tested there. Please compare the results with your live site.

I would defenitely suggest applying this fix, as the fact that the site URLs were not created correctly is even worst for SEO.

The English course is available:
hidden link

The issue appears to be that inside the WPML language switcher the language directory is missing.

It is realted to the changes inside the functions.php file fo the Child Theme. Take note again, that the original code here was not considering that the site is multilingual. I tried fixing this using WPML compatilbity code, but it is not fully working.

Until now I was not able to find a solution for this. I can offer to give it a nother try later today but I can not promise at this moment to find a working solution.

Further, I am not able to escalate this issue to Second Tier, as it is not a WPML issue and only occurs because of the custom code inside the Child Theme.

I would suggest you consider to consult one of our contractors:
https://wpml.org/contractors/

It would be generally advisable to reach out to the contractors in such cases.

Our support does not have the capacities for debug and fix issues that occur due to custom code. The custom code on your theme was not coded in a way that it could work with WPML.

I can offer to have another look into this, but take note that the time that we can dedicate on each ticket per time is limited and I can not promise to have a quick solution for you.

I can currently not access your site, as possibly disabling "Secure Custom Fields" triggered an error in the child theme.

This usually happens if the child theme calls ACF Fields and does not validate if SCF is active or not - it is a common developer mistake.

I could fix this issue, by uploading a file to the server that allows me to access the database and then activate a different theme by changing the option value manually.

Would you agree on that?