Background of the issue:
I am trying to have better multilingual support for Yoast SEO sitemaps on active WPML installations, using the "glue plugin" WPML SEO. In wpml_wpseo_loads_first(), the incorrect assumption is that WPML Core would always load sooner than WPML SEO, which might not be the case. The solution would be to first look for the current index of WPML Core and insert WPML SEO right after that index.
Symptoms:
Each domain sitemap listed all posts of different types regardless of the active domain language. WPML SEO's filters and actions weren't executed because WPML_Core_Version_Check::is_ok was returning false. ICL_SITEPRESS_VERSION was NOT defined, making that function return false. This was caused by WPML Core loading later than WPML SEO.
Our second-tier supporter would like to know if you can provide a real scenario (steps) for replicating this problem.
Alternatively, provide a package of your site where we can reproduce the issue.
If it is a package you can provide or access to your site where we can see this issue, a private message is enabled for the following reply.
Privacy and Security Policy
We have strict policies regarding privacy and access to your information. Please see: https://wpml.org/purchase/support-policy/privacy-and-security-when-providing-debug-information-for-support/ **IMPORTANT**
- - Please backup the site files and database before providing us access. --
-- If you have a staging site where the problem can be reproduced, it is better to share access to the staging site.--
- Install latest versions of WP, Yoast SEO, WPML Core and WPML SEO. Configure WPML to use domains instead of folders.
- Have a CPT with some posts in several languages.
- Write a script to manipulate the option value of "active_plugins", so you can read/write to the option value easily.
- When you read the option value WPML Core should be at position 0 in the array, WPML SEO should be at position 1.
- Re-order the loaded plugins in "active_plugins" by putting WPML Core after WPML SEO.
- When viewing the CPT sitemap in the list of sitemaps on /sitemap_index.xml, you'll notice that all posts are visible in that sitemap for all languages, not the current language only.
- That's because no filters and actions of WPML SEO are loaded because of the order assumption in "active_plugins".
When developing, you should never assume anything, you should be 100% certain at all times, if not, build in checks and fallbacks to be sure.
My suggestion would be to rewrite wpml_wpseo_loads_first() in plugin.php and look for WPML Core in the list first, and put WPML SEO right after that found index.
I've added code to the themes functions.php file, at the bottom. With comments.
After updating that file and navigating to the home, sitemaps are incorrect: hidden link
When I go to hidden link, I only see links to English posts, and each link is tripled. Moreover, I don't see the links to the French and Spanish posts. They are missing. Please see the attached screenshot.
Can you please confirm this is a good description of the problem?
The posts you see are all posts in total but displayed with the english permalink. It's because no actions and filters are executed by the WP SEO plugin.
