Background of the issue:
I am trying to upload an SVG in place of another SVG as a Media Translation using WPML. The issue can be seen here: hidden link.
Symptoms:
When using Safe SVG (as we do succesfully for years), after uploading the image, I get, instead of the right image, this image :/wp-includes/images/media/default.png image.
With SVG Support instead of Safe SVG, I get a 'Security check failed' message.
However, I can upload an SVG file from the Media Library, whatever the SVG plugin I use.
This issue occured after updating WPML plugins (amon which) Media Translation to their very latest versions
It's been reproduced on 3 environments, and in a minimal environment with only WPML plugins and Storefront theme.
Questions:
Why can't I upload SVGs through WPML Media Translation anymore?
WordPress does not support SVG by default and the support is added via 3rd party plugins (or custom code). Most of these may not be compatible with WPML, like the "Safe SVG" which I can't find on our compatibility list.
I'll recommend checking with the plugin author, because I see the plugin was updated some months ago (https://wordpress.org/plugins/safe-svg/) and may need a compatibility update.
Theme and plugin authors are welcome to join WPML’s Go Global program, which helps them make their code multilingual ready. Together with WPML’s compatibility team, they can test and confirm that their theme or plugin works with WPML. See https://wpml.org/documentation/support/go-global-program/ for details and you can refer your theme/plugin provider to this as well.
I'll contact them.
However, SVG support is the one you seem the closest to support, while requiring a patch. As mentionned, this patch doesn't seem to work either.
Coud you create a test environment where we could reproduce the issue?
The only requirements seem to be WPML + WPML Medias + Safe SVG plugin.
That'd probably a good start on the way to an SVG upload plugin compatible with WPML?
Sure, I've created hidden link (one-click login). Remember to configure WPML as needed and add your desired SVG plugin, before going to reproduce the problem.
About the SVG Support plugin, that's still not compatible with WPML and our team has tried several times to contact them and even created a report in their support, which was closed without resolution, a long time ago.
You may try the fix provided for the SVG Support plugin, but with only this plugin and its latest version. This fix may not work for Safe SVG plugin.
Again it is better to check with Safe SVG support and get any relevant/technical information and then I can check with our team for any possibility.
I configured the environment to perform the same tests as in my local environment.
1. I activated WPML Media Translation
2. I adde both Safe SVG and SVG Support plugins, to have both available to troubleshoot them alternately.
3. I uploaded an SVG image file (with Safe SVG enabled), from the library, and added Title and Alt metadata
Results :
1. With Safe SVG : Translating the image by uploading an alternative image in WPML Media gives the same result as I get in my environment.
hidden link
2. With SVG Support activated instead of Safe SVG, I also get the same results : "Security check failed" (see attached)
3. If applied the suggested patch to function.php (:339) , same results.
In the end both of these plugins allow to upload SVG to the library, but none of them allows to translate SVG to WPML Media *anymore*. While both obviously still used to until very recently.
I consulted with the team and looks like there's the problem with the SVG image itself. Because I just tried with another image and it worked just fine.
You can login to the same sandbox site and try yourself. I've activated Safe SVG plugin at the moment.
Please try different SVG images, I got some from hidden link and not every image here works as well. So probably there's the issue in how SVGs are being generated.
The image(s) I tested could be uploaded from the library.
If I export an svg that's already been uploaded as a translation through WPML Media Translation (which attests it *used* to work with that specific file), if I upload it again, it fails.
Why would it be different when processed through WPML Media Translation?
By the way, I tried to upload the adobe logo (from your list)
>> Can't upload through Media Translation
>> Successfuly uploads through the library.
Still, I noticed the file was appended -1 >> adobe-1.svg (french library). Which is a sign that the image was somewhat processed, and saved in the db.
Media Translation obviously adds a layer that prevents many svg to be properly uploaded, and it's new.
Therefore, I tried to test against previous versions of code by downgrading WPML Media trough the CLI. the cli sayed it wordk, the admin kept saying WPML Media Translation was still in the lastest version. So that I didn't know where I sit.
Thank you for the updates, I've checked on those lines already, however, I gave it a fresh try again, here's hidden link">my screen recording.
As you can see that this is even not reproducible anymore, not even with the same image I had tried previously. I can upload SVGs to media library in any language and then can add translated version vis Media Translation as well.
Yes, its true that when I upload via media translation, the preview of uploaded image isn't available at first, but after saving it is visible in Media Translation page, as well as, if I click edit again.
Can you try in a different environment? And if you do and find the same issue there, please provide the temporary access (WP-Admin and FTP), preferably to a test site where the problem has been replicated.
Your next answer will be private, to share this information safely.
Also provide detailed steps to reproduce the issue and links to pages in the admin and on the frontend.
IMPORTANT: Please take a complete backup of the site to avoid data loss. I may need to activate/deactivate plugins also.
To make it short, you say the issue doesn't even occur *anymore*... "not even with the same image I had tried previously."
I noticed it, you tested it, you noticed it as well, we both reproduced it on your test environment...
So, I just did the as well on your test env., and indeed it works.
So I did a new test, from *my* environments (my website), same tests as I did las week, and it works as well!
How comes it's different now?
The plugins versions didn't change, WP neither...
Something **must** have changed in the meantime.
nb: I did a small config adjustement to meet the expected behavior on our website (see attached).
Well I'm also surprised and can't find a logical reason to this, that nothing changed in terms of WP and Plugins and it is working now.
In the sandbox, I didn't even change that setting which is by default turned off. That setting simply adds a DB record for the same image, for other translations. Since it is off by default, the same image is used without a translated DB entry.
Anyways, I think we can close here as issue isn't reproducible anymore. However, please free to report back if you find any clue or even open a new ticket if anytime in future it happens again.
